Skip to content

Constraint bugs#49

Closed
Aurige wants to merge 2 commits into
TransmodelEcosystem:masterfrom
Aurige:Constraint-Bugs
Closed

Constraint bugs#49
Aurige wants to merge 2 commits into
TransmodelEcosystem:masterfrom
Aurige:Constraint-Bugs

Conversation

@Aurige
Copy link
Copy Markdown
Contributor

@Aurige Aurige commented Feb 22, 2019

Addition of EquipmentPlace that was missing reference in the Place_AnyVersionedKey key constraint

Addition of EquipmenPlace that was missing reference in the Place_AnyVersionedKey key constraint
@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Feb 22, 2019

@Aurige could you please not change things like the description etc. in the same pull request? Hence split it in two, send a pull request for only the description. Then I'll will merge this one after that one is merged.

@Aurige
Copy link
Copy Markdown
Contributor Author

Aurige commented Feb 22, 2019

Sorry, which description are you talking about ?

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Feb 22, 2019

Line 19-55

@Aurige
Copy link
Copy Markdown
Contributor Author

Aurige commented Feb 25, 2019

Ok, that's not a comment change... just a reorganisation of the layout automatically done by XML Spy (no change in the content) .... I will unset this feature for next PR

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Feb 25, 2019

In that case, that requires that you would run our xmllint script on your repo, so the organisation retains the same format. See this commit: c07c885

@Aurige
Copy link
Copy Markdown
Contributor Author

Aurige commented Feb 25, 2019

just tried it, but it looks that the behaviour is not consistent from one environment to the other: I ended up with all files slightly changed .... So I just unset the option in XML Spy so this will not occure any more in future PRs

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Feb 25, 2019

I'll try to resolve your request later.

@skinkie skinkie closed this in 17c3b06 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants